onalante-msft

Results 16 comments of onalante-msft

Marked as draft since there is still work to be done on gating the reporter modules behind feature flags. However, I am open to comments on the current changes.

I split off the ptrace code to #1067. I have marked it as a draft to prevent it from getting merged as it still has a failing test that needs...

Marked as draft since `kill_used_in_test` is failing with a segfault originating in `rusty_fork`.

The choice to keep the inner `UnixStream` private seems to match what hyper does with `AddrStream`: [reference](https://github.com/hyperium/hyper/blob/bff977b73ca8d737f5492c86c09fd64735c45461/src/server/tcp.rs#L206-L210). Though the latter type does have an `into_inner` to get the backing `TcpStream`,...

Oh, I completely missed that `UnixStream` was not exported from `lib.rs`. My sincere apologies about that! I should have looked more closely at the export declarations. I agree that making...

If by "wrapped" you mean something like `socat UNIX-LISTEN:... TCP:example.com:80`, there is no way for `hyperlocal` to know what the underlying host should be if you are using a client...

Sorry this took so long to review. I had this on my to-do and forgot about it.

https://github.com/kube-rs/kube-rs/pull/900#discussion_r867544769

It is possible to only require `futures-util` and `futures-channel` in dependents while preserving documentation links by restoring `futures` as a regular dependency gated behind a feature flag only used for...

> I tried it locally with `make doc` and the links in `watcher` does not resolve, even with the feature. That is unexpected... I just tried `make doc` on a...