Curtis Vogt

Results 388 comments of Curtis Vogt

I can get behind this but there are a couple of things to call out: - Key existence is used to check the presence of components. We'd need to use...

> Do you see alternatives? Approaching this from the perspective of the user of `splitdef` we need a way to consistently determine whether the expression defined a given feature. If...

The `splitdef` function is throwing an error here as it only can handle processing of function definitions. What I would do in this case is have your macro remove any...

You should be able to drop the `mod` requirement if you instead used `__module__`. Definitely worth a PR!

My bad there. I was still thinking about the `@foo` and `@bar` macros. Can you provide more context with what the `@foo` and `@bar` macros are going to be doing?...

That's reasonable. I'd have to think about naming a little more here

``` CURLE_RECV_ERROR (56) Failure with receiving network data. ```

Wow, I'm not sure how I missed that... I think where it's located in the documentation is fine but I would make `minikube start` link to https://minikube.sigs.k8s.io/docs/commands/start/

> Could this be added to the project or is it out of scope? This is most definitely in scope. The `get_pod` function runs within the current namespace used by...