actions-setup-minikube icon indicating copy to clipboard operation
actions-setup-minikube copied to clipboard

Document `start args` parameter

Open omus opened this issue 3 years ago • 2 comments

After looking through the code I noticed startArgs: https://github.com/manusa/actions-setup-minikube/blob/965c2006a2cf6c24971b6419ccacf46a2c1b0065/src/install.js#L25-L27 It would be great if this features was documented as some minikube features like --cni have to be set during minikube start

omus avatar Apr 16 '21 15:04 omus

Hi @omus, There's already documentation about this in the Optional input parameters section. However, if you missed it, it's probably not in the best place, or missing emphasis. Do you have any suggestions to improve this?

manusa avatar Apr 21 '21 05:04 manusa

Wow, I'm not sure how I missed that...

I think where it's located in the documentation is fine but I would make minikube start link to https://minikube.sigs.k8s.io/docs/commands/start/

omus avatar Apr 23 '21 13:04 omus