Owen Smith

Think I got this in _1.0.0_, let me know

Sadly, I'm pretty sure this is now much more broken than before. Gave omsmith/browserify-1192 a test, and duplicate filenames are overwritten. Seems the solution is to just be able to...

Thanks for taking a look through the issues. Happy to accept a PR adding a note around this.

It _should_ support plain node `IncomingMessage` (be sure to pass both `req`, and `body`), express requests, and hapi requests. Happy to accept a docs PR if you're able

Yeah, I'd looked at it briefly. Between proxies and storing tool settings on the consumer and all that, it's a must more pervasive situation than just checking signatures. Would need...

> +1 for require("fs/promise") vs require("fs").promised blocking unflagging but nor PR. I'll echo that. Don't think I'd want to see `.promised` end up as an actual API, but if it's...

@chrisdickinson Apologies if I missed it in the PR thread (was hard to track all that). Would you (or someone else) be able to sum up: - Is the reasoning...

Benefits of having `fs/promise` and/or the `.promised` shortcut: - nit: I don't have `Async` or `Promise` all over - nit: The presented functions are _only_ `Promise` returning ones, which is...

Perhaps, but I think it follows along with some comments I saw in the original PR: - Don't want to affect the callback functions, performance wise (increased base memory usage...

Additional note, this `ArgumentException` also occurs when creating/updating a Check Run (e.g. `client.Check.Run.Create( ... )`), since it attempts to parse the response body into a `CheckRun` object.