Omry Yadan
Omry Yadan
I think the flags argument is a later addition. Ensure container is not supposed to mutate the input so it makes sense that the flags is not set. We can...
Note that this behavior is well documented in 2.0 and the docs will have to reflect this change. This extends to boolean as well. Note that merge should still support...
Non string keys are new in 2.1, so there are no backward compatibility concerns. I am okay with not supporting them in interpolations for now, but it's better to raise...
> > Non string keys are new in 2.1, so there are no backward compatibility concerns. > > The potential concern would be that if we implement it, then `${0}`...
Tentative for 2.1, if we can fix it without grammar change.
Bouncing to 2.2.
I am okay with changing the check to `isinstance(value, (float, int, str))`. By the way: If numpy floats works, people would also expect assignment of a ndarray of floats to...
> This only partially solves the issue, since there's no guarantee for numpy floats to inherit from float (see @Jasha10's comment above). Looks like numbers.Number catches it: ```python In [20]:...
Side note, we should probably change the error: ``` ValidationError: Value '-0.6931471805599453' could not be converted to Float ``` to something like: ``` ValidationError: Value '-0.6931471805599453' of type 'np.float` could...
I have never heard or used of IntEnum, is this something we actually care about? If this is an Enum, it should use an EnumNode, not an IntegerNode.