Omer Tuchfeld
Omer Tuchfeld
/remove-lifecycle stale
Adding to @xiaogwu's answer: - The flags `--name`, `--icon`, `--honest`, `--bounce` and `--counter` are not required and are not relevant to this issue, only `--internal-urls` is relevant. - If you...
/test pull-cluster-api-provider-gcp-e2e-test
> @omertuc, where did you see the failing tests (not running)? Could you provide before and after? I haven't literally seen it happen in this particular instance, I just know...
This short recording demonstrates that: https://asciinema.org/a/0rMFOEAtFdh0fb5Va743VVBKN before the fix, no matter what the parameters of the first loop iteration are, the test is passing. after the fix, the test parameters...
/remove-lifecycle stale
/lifecycle frozen
Interesting, I'll try to debug and see why it didn't. That piece of code is actually where I got these from but didn't realize it's supposed to happen automatically
>there's been no reply Yeah haven't had time to look into it, i've tried to use `strcoll` instead of `strcasecmp` but for some reason it still doesn't respect locale, not...
>Functions like strcoll() assume you've called setlocale() with appropriate values Ah ok. My assumption was that just setting the environment variable should be enough, didn't realize setlocale() has to be...