Omar Khaled comments

Results 18 comments of


                                            Omar Khaled

[LineChart] Proposal: TooltipItem with Widget child.

Yes it is a cool feature to have custom tooltip widget, I can't even add simple elevation to my tooltip 😕.

[go_router] Support return data from a screen with pop()

Any updates 🥲

[go_router] onExit does not work correctly after swipe to pop on iOS

I see now why Flutter disables swipe to go back when using the WillPopScope widget, hope this fixes it without disabling the gesture.

Update pubspec.yaml

lots of dependencies are depending on Web 1.0.0 now, lets please get this merged!

Add button to copy `.diff` file content directly from GitHub Desktop

Hoping this can be reconsidered, as a native "Copy Diff" feature would be a significant improvement.

Remove references to deprecated v1 Android embedding

This plugin is already using the v2 Android embedding by implementing FlutterPlugin with onAttachedToEngine and onDetachedFromEngine. The main migration step is to remove any leftover references to the old v1...

[go_router] Support for top level `onEnter` callback.

Hi @chunhtai, This PR introduces a top-level onEnter callback, addressing critical gap in go_router’s handling of deep links and redirect customizations. It allows developers to intercept routes, block navigation, or...

[go_router] Support for top level `onEnter` callback.

Hi @chunhtai, Following up on this PR. I've updated the implementation to: 1. Enhance OnEnter signature to include current and next state: ```dart typedef OnEnter = bool Function( BuildContext context,...

[go_router] Support for top level `onEnter` callback.

Hi @chunhtai, I've expanded the `OnEnter` callback again to include a `GoRouter` parameter to handle early-stage navigation. This addition addresses an edge case where navigation is needed before the `InheritedGoRouter`...

[go_router] Support for top level `onEnter` callback.

Hi @cedvdb, The callback signature is indeed straightforward. The fallback router isn’t ideal in that it isn’t coming directly from the widget tree (via GoRouter.of(context)), but it serves as a...