Ondřej Lysoněk

LGTM from technical point of view.

> vm.swappiness should be set to 30 according to the include profile 'virtual-guest', however, it is set to 60 which is the default value after a reboot. You're using `replace=1`...

> I used to believe that only the conflicted parameters in the sysctl section of the included profile would be ignored. For instance, if vm.swappiness is also defined in the...

Am I missing something, or do the `isolated_cores`, `ps_blacklist` and `ps_whitelist` options of the `scheduler` plugin provide the required functionality? These have been introduced in commit ac78f90c773cc97573844f521c2f67291f15d354.

I'm still missing a justification why the directory should not be world-readable. This will hurt user experience, so it needs to be well justified.

Hi, yes, I think a per-instance option `ignore_removable_flag=True|False` would make sense. You could use it as follows to ignore the flag in `sda` but not in `sdb`. ``` [disk_sda] type=disk...

I think there might be some security considerations to this feature. I think there is an expectation in Tuned that the data that Tuned reads from the system is trusted,...

Thanks for the tip! We're generally trying to avoid using external programs in newly written code and instead use libraries or our own code. We'll also rewrite the `disk` plugin...

You should put your custom profiles and scripts to `/etc/tuned//`. `man tuned.conf` may help.

> `man tuned.conf` may help The man page is slightly outdated. You should use `script=${i:PROFILE_DIR}/profile.sh`. https://github.com/redhat-performance/tuned/pull/163