Olivier Spinelli

Results 17 comments of Olivier Spinelli

Hello, Covariant return type is now available (as of C#9). See here: https://anthonygiretti.com/2020/10/12/introducing-c-9-covariant-returns/ It seems to me that the type safe code (no more need of the "general" object return)...

Cool! I'm not crazy! So let me explain what I'm trying to do: a maximal encapsulation of all this JWT stuff to be used by "Application developpers". I'm looking for...

Please note that the `JwtDescriptor.Header` implements the exact same behavior. It seems that the intent was (for the `JwtDescriptor.Header` at least) to support both: - Preconfiguring headers from constructors (typically...

Ok. I understand... I think I have good news: thanks to the new C# 9 "init" keyword, there is a really clean solution that I pushed here: https://github.com/uruk-project/Jwt/pull/539/commits/fd09a2a0d8376ef0ce6dda603f1460f70ee0595c That's a...

Hello, I've seen that you have integrated the Payloald and Header setter. I have 2 remarks: - It seems to me that the Payload is a very independent beast (as...

You're right: this is a bug (but FYI, this is not an _"extra unboxing"_, just a _downcast_). The first thing is to write a unit test for it (in DataReaderTests):...

@brogdogg I'm 52 (taught C# and developing all day long) and I'm complaining a LOT!

Hello, Glad that this PR caught the attention! The "why" is rather basic: I have a IThing at compile time, only at runtime do I have a Thing class that...

Okay... This may appear surprising but I'll try to explain below: - An abstract package defines a `public interface IPoco {}`. - The package `UserManagement` defines a `public interface IUserInfo...

BTW, I just realized that you may have addressed this bug: https://github.com/DapperLib/Dapper/issues/1822 because I see now a wrapper around the reader (but the issue is still opened). I also fixed...