Oliver Klee
Oliver Klee
> As a first step, we could add a new CssInliner class that uses the new interface and redirects most of its work to the old Emogrifier class (and has...
> I guess that until 2.1.0, enhancements/fixes would be applied to both CssInliner and Emogrifier, but after that there would be no need to maintain the old class. Up to...
Now that I've thought about it a bit more, we could mark the Emogrifier class as deprecated in version 3.0.0, and recommend using the new class. Then we could leave...
Please let's move this discussion to #516.
@vanderlee Great, thanks! Actually, the performance tests should not be PHPUnit tests, but just some PHP scripts that generate some numbers (and be it that they provide some bigger data...
Tests/Performance/...Test.php Tests/Performance/TestData/....html, ....css
The unit tests code coverage (regarding both the lines and the functionality) is almost perfect. The only thing not yet covered is the first-child/last-child/nth-child functionality. This functionality currently is broken,...
We can put the performance tests into a Composer script.
Hi @maoxiong, thanks for the bug report. Are you referring to the conversion of CSS into non-CSS style-related HTML attributes, or to the CSS that is left untouched in the...
Thanks for the clarification. Could you please attach the input HTML and CSS, the current output HTML, and the HTML that you would expect to be generated? Thanks!