Oliver Klee

Results 269 comments of Oliver Klee

@JakeQZ Do you have experience with CSS parsing libraries and can recommend one?

I'll need to do some more research on the recommended maximum line length for Markdown. 120 might be less common than 80 characters.

@SpazzMarticus Thanks for the feature proposal! Would you be willing to create a PR for this?

Yes, I'd like to have this (in some way or other). I'm thinking of some thin facade class that can be instantiated (and that might implement some interface or not)...

I disagree. I think that it's important that we provide a clear contract, i.e.: - public methods = a promise that those won't change except with a new major release...

I was referring to people needed to call a currently-private method. In that case, I'd prefer us to make it protected/public without `@internal`, i.e., make it API with a promise.

I think we might want to go through our _current_ public and protected methods and check which are not part of our current public API and should be marked as...

> I'm aware of several classes marked `@internal` which I assume suffices for the entire class. Yes, that's the way I understand (and intended) this as well.

Closing as per our current [API and deprecation policy](https://github.com/MyIntervals/emogrifier/blob/main/docs/API-and-deprecation-policy.md).