Oliver George
Oliver George
Throwing my very late 2c in. A configurable dispatch-fn takes the pressure off picking names here. The event could become _any type of data_ and `*dispatch-fn*` is the mechanism to...
Opening up to supporting anything might open up new audiences. Specifically, JS object support might reduce friction in regular JS components/libs. The dispatch function would be important for this to...
This repro was done using vanilla clojurescript REPL (as per the getting started guide). I think it's good to consider the REPL experience rather than relying on hooks associated with...
Here's a concrete suggestion. What if the cache invalidated when a subscription was re-registered. The cache should definitely not be trusted in this case since the subscriptions would be out...
Thinking about possible complexities / side effects... Clearing the subscription cache doesn't appear to trigger a re-render of the app. We can clear the cache without other code running (good)...
Here's a possible approach which modifies `reg-sub` https://github.com/day8/re-frame/commit/57959c21d0ec00bab71bcb23fd5a3fd32e280223
Thanks for putting this together. I vote this :fx form ```cljs (reg-event-fx :token (fn [{:keys [db]} [_ id]] {:db (assoc db :something id) :fx [{:dispatch [:blah]} ;;
Using a `(ref-fx :fx ...)` would be backward compatible (technically) and `:db`, like `:dispatch`, could work in both places. Problem is that if `:db` appears twice it would cause a...
> reg-event-fx2 > @olivergeorge I'm unclear on your reg-event-fx2 proposal (duplicated below) > > (reg-event-fx2 :token (comp set-something fetch-data dispatch-other)) > Are you suggesting a new registration function which sets...
I think this is off topic but noting here as it relates to the **should :fx be a list of maps or vectors** which impacts fx handler calling conventions. Most...