Oliver Foster comments

Results 103 comments of


                                            Oliver Foster

API should throw errors when appropriate

* API functions throw when failed - with standardise properties, stdout/stderr * API functions to use logger properly with .warn and .error where appropriate (**pluginInstall**/build/etc)

update fails if a plugin is not bower registered

I can't replicate on version 3.1.4 in either case, for adapt update and adapt ls. I've tested with a local plugin and with a non existent plugin in the adapt.json...

update fails if a plugin is not bower registered

That helped. Thanks.

use adaptlearning domain for registry rather than heroku

current url http://adapt-bower-repository.herokuapp.com/

v6 registry issues

or make sure it's always an object up front and change everything else accordingly? save having type switching logic in all the commands?

Cannot update non-prefixed plugin

should we support this? would it not be better just to have absolute names?

Cannot update non-prefixed plugin

Cool. I'd be in favour of dropping this to simplify the future requirements.

Cannot update non-prefixed plugin

I'm suggesting it shouldn't, npm won't support optional prefixes.

Sanitization method for preventing CSV injection

I don't see any mitigation for injection in this library. I can see appropriate warnings about how users need to consider mitigating CSV injection. Warnings: https://juanjodiaz.github.io/json2csv/#/others/known-gotchas?id=avoiding-csv-injection No mention of CSV...