adapt-cli icon indicating copy to clipboard operation
adapt-cli copied to clipboard

Cannot update non-prefixed plugin

Open tomgreenfield opened this issue 4 years ago • 5 comments

When trying to update the core-bundled Vanilla theme:

$ adapt update contrib-vanilla

No valid targets specified (please check spelling and case).

This only works if I type the entire name, adapt-contrib-vanilla.

tomgreenfield avatar Mar 26 '20 09:03 tomgreenfield

should we support this? would it not be better just to have absolute names?

oliverfoster avatar Mar 26 '20 10:03 oliverfoster

Just mentioning because it's a regression – I never bother to type the adapt- prefix, as per the README.

tomgreenfield avatar Mar 26 '20 10:03 tomgreenfield

Cool. I'd be in favour of dropping this to simplify the future requirements.

oliverfoster avatar Mar 26 '20 10:03 oliverfoster

it does say here that the 'adapt' prefix is optional

moloko avatar Mar 26 '20 15:03 moloko

I'm suggesting it shouldn't, npm won't support optional prefixes.

oliverfoster avatar Mar 26 '20 17:03 oliverfoster