Olivier Girondel

Results 87 comments of Olivier Girondel

Hi Laurie, I'll give it a try when I can get some time, $WORK is keeping me busy. On January 5, 2022 7:20:55 PM GMT+01:00, Laurence Tratt ***@***.***> wrote: >Change...

From a quick glance, I would say it looks ok, still the return of pselect() should be checked for errors (-1) On January 5, 2022 7:20:55 PM GMT+01:00, Laurence Tratt...

All system calls MUST have their return value checked for errors, or mayhem can happen. So even if we decide to ignore them, a failure should be at least `syslog()`-ed,...

`ENOMEM` usually means bad things.

Adding two lines (pselect() returns -1 => syslog() that), or do the right thing in case there was no error shouldn't be *that* hard to add to this PR IMHO.

@davidmeirlevy Hi, I tried upgrading to `^2.0.0` but I get this error: ``` Failed to compile. ./node_modules/vuex-composition-helpers/dist/util.js 52:20 Module parse failed: Unexpected token (52:20) You may need an appropriate loader...

I tried adding `esnext` and `esnext-loader` using `yarn`, but same result.

For the record, adding `transpileDependencies: ['vuex-composition-helpers']` to `vue.config.js` did the trick.

The warning/error goes away if I use the `+` operator, e.g. ``. Is this what should be done ?

This is **definitely** a clever solution.