Aleksander Nowodzinski

Results 105 comments of Aleksander Nowodzinski

For the record, it looks like the table insertion grid should handle keyboard differently because when reaching the right boundary of the grid, the right arrow key should not move...

Notes from the recent meeting: * Let's use `editor.config.ui.name` for configuration. * For the time being, no properties such as `Editor#name`. * If a feature wants to know the name...

> To provide the incremental `EditorN` label for editors without `editor.config.ui.name` config I think we should use `editor.config.define()` instead of [generator proposed in the PR](https://github.com/ckeditor/ckeditor5/pull/11998/files#diff-970806b92adc17e426eb9adebce8d665254e9dd71b283c6491c9dfdffe7a1be8R453). [We're doing this already](https://github.com/ckeditor/ckeditor5/blob/b0a183e5ddf131625d6c9c26fc575269e55890a1/packages/ckeditor5-core/src/editor/editor.js#L82-L83). I...

> ``` > label: this.config.get( 'ui.name' ) > ``` Because there must be a place that takes care of unnamed editors and increments "EditorN". Preferably by setting `editor.config.define( 'ui.name', Editor${...

An update: After a F2F with PK we figured that we're gonna change the API for our editors' UIs `ClassicEditorUI`, `InlineEditorUI` etc. and implement `ClassicEditorUI#setView( view: EditorUIView )` This will...

> Does this have any impact on multi root editor implementations that people have? I mean changing how the view is set? It should not because we're not changing the...

I noticed that this PR does not address the issue of the "Show more items" toolbar staying visible. I forked this PR and addressed the issue there #12319 + some...

Some rough ideas: ![](https://user-images.githubusercontent.com/1099479/176455099-ea3d3651-0b8d-490e-8722-bf072741285d.png) ![](https://user-images.githubusercontent.com/1099479/176455126-0a05ad15-d56a-48e6-9fe3-d53917cf3bd8.png)

Some new ideas (or just confirmation of what we came up with) in this ticket: #6765.

> or just replace the grid by 2 inputs That would make the UI nearly useless for anyone using mouse so it's definitely a no-go. The grid is one thing...