Aleksander Nowodzinski

Results 105 comments of Aleksander Nowodzinski

I created a similar PoC one day to solve some other issue (don't remember which one) and the biggest issue was that the panel must follow the toolbar when things...

Not really. We can improve the panel positioning algorithm. It can detect not only the viewport boundaries but also ancestors with `overflow: hidden`. No changes to the DOM structures or...

At first I thought the bug is somewhere in `EditorUI#addToolbar()` and the whole focus management and navigation on Alt+F10 but it does not look like the case. It's more likely...

> I have found one small issue here - document lists don't work together with blockquotes despite documentation saying they should. @Acrophost Since this PR is about docs only, could...

There's one problem left that I identified but this is beyond the scope of this issue. It is related to the balloon logic and there's no easy workaround other than...

@ckeditor/qa-team Could you please check this out? ## Requirements * Check out `ck/10368-source-editing-focus-toolbar-v2` branches in ckeditor5 and collaboration-features. * Start with the all-types manual test [http://fake.ckeditor.com:8125/ckeditor5/tests/manual/all-types.html.](http://fake.ckeditor.com:8125/ckeditor5/tests/manual/all-types.html.) Then get creative 😛...

Use-case to fix: when pressing Alt+F10 in a toolbar when there's no other toolbar to focus: * nothing should change (expected) * focus moves to the first item in the...

Use-case to fix (low priority): when pressing Alt+F10 in a toolbar when some dropdown is open and the focus moves to another toolbar, the dropdown should close.

* I fixed the balloon toolbar issue [https://github.com/ckeditor/ckeditor5/pull/12064#issuecomment-1216584257.](https://github.com/ckeditor/ckeditor5/pull/12064#issuecomment-1216584257.)  * I somehow made [https://github.com/ckeditor/ckeditor5/pull/12064#issuecomment-1216633694](https://github.com/ckeditor/ckeditor5/pull/12064#issuecomment-1216633694) less visible but I couldn't get rid of the issue in some scenarios. This is a problem...