Olek

Results 15 comments of Olek

> One thing I did find is that traditional deposit auth will override the credentials. Meaning if the destination adds deposit auth credentials, then deposit auth's my account, I dont...

Rebased with the latest develop.

Changed functionality for credentials creation: - Issuer must be present in the Ripple ledger. - Credentials can be created by issuer only and accepted by subject. - Shared node ownership...

Squashed and rebased on the latest develop

Rebased with latest develop

Maybe you forgot to commit but I don't see expired NFT offer tests

I'm taking ownership of the implementation. But I can't commit to this PR due to some permission issues. Everyone please move to [XLS-80d_new](https://github.com/XRPLF/rippled/pull/5161). I made fixes based on comments here.

There is a function `wasm_module_validate` https://github.com/bytecodealliance/wasm-micro-runtime/blob/main/core/iwasm/include/wasm_c_api.h#L554 You should use it in module protection flow

I think it worth to understand what that `wasm_module_validate ` do and why it allow empty module to pass

As it was found out `wasm_module_validate` don't do any additional checks, except it load the module. I've created other [PR](https://github.com/XRPLF/rippled/pull/5517) which will check the module, parameters and imports. Just not...