Olivier Lamy comments

Results 337 comments of


                                            Olivier Lamy

Jetty p2 site is empty

this should be fixed with this commit https://github.com/eclipse/jetty.project/pull/8034.

Add --add-to-start=<url> support for easier remote module install

@joakime sounds like a good idea. Still a need to implement it?

remove jetty-annotations dependency from websocket-jetty-server

ah yup that's more changes... but not so trivial. I will resume after holidays.

Javadoc search returns broken links

This has been fixed with https://github.com/eclipse/jetty.project/pull/3780

Javadoc search returns broken links

Will be with next release On Fri, 9 Aug 2019 at 2:52 pm, Gili Tzabari wrote: > @olamy How could this have been fixed by a > merge from June...

Javadoc search returns broken links

uhm building locally from `jetty-11.0.x` doesn't have any issues. weird. I will check with @jmcc0nn3ll how is it deployed.

Test resources need to be transformed to ee8

fixed https://github.com/eclipse/jetty.project/commit/68206ce880a334d02fa381adf03fe01e2e5b2015

The maven plugin is using the last available docker which is 2.6.0 see https://github.com/jetty-project/h2spec-maven-plugin/blob/5ac3283e1c426502610d7458a5adbf57dee1f643/src/main/java/org/mortbay/jetty/maven/h2spec/Http2SpecMojo.java#L136

Review mechanism to scan jars from class-path and module-path

give it a bit of time

Do not depend on system clock

happy to work on that. Should we use a pattern such (each change need to be reviewed) ``` System.currentTimeMillis() -> TimeUnit.MILLISECONDS.convert(System.currentTimeMillis(), TimeUnit.NANOSECONDS) ``` ?