Okue

Results 11 comments of Okue

As Implementing gRPC server interceptor is a bit annoying to me, I implemented some logics (such as authentication, rate limit) with armeria decorators. In error cases, my implementation returns the...

Maybe, I should have implemented the logic at not the decorator but grpc-interceptor like this example. https://github.com/saturnism/grpc-by-example-java/blob/master/metadata-context-example/src/main/java/com/example/grpc/server/JwtServerInterceptor.java#L51-L54

BTW, I noticed `listener` is null in `ArmeriaServerCall.invokeOnCancel()` if `serverCall.close()` is called by `io.grpc.ServerInterceptor` as the above example code. https://github.com/line/armeria/blob/8a1281f1d2b827f516247b8f9eb6210f2a047efa/grpc/src/main/java/com/linecorp/armeria/server/grpc/ArmeriaServerCall.java#L492-L501 NPE is just ignored, because `Throwable` is caught and `closeCalled`...

Yes, I want `armeria-spring-boot-starter` to support this kind of feature.

Unsend & Video play complete events will be implemented by #284.

This will be done after #410.

Do you suggest `__repr__` implementation should be modified so that it prints like this? ``` message: { file_name: ..., file_size: ..., ... } ```

Thanks for opening the nice issue.

First, we should separate [`LineBotCallbackRequestParser#handle(String, String)`](https://github.com/line/line-bot-sdk-java/blob/3.1.0/line-bot-servlet/src/main/java/com/linecorp/bot/servlet/LineBotCallbackRequestParser.java#L75) from `LineBotCallbackRequestParser`. This function will be used as an utility by both `line-bot-spring-boot-webmvc` and `line-bot-spring-boot-webflux`.