Kevin Masson

Thanks for the review @fedormatantsev and @dictoon :) I commented some of your remarks.

Hi @ChinYing-Li, Thanks for updating your PR. Regarding naming, I was referring to the commits and not the PR title. You should name your commits correctly following those rules :...

Hi @ChinYing-Li, Thanks for the changes ! No worries about the rules. It's a habit that you will take very easily :)

@ChinYing-Li No problem, it's normal to do this kind of mistake when doing your first pull requests. All the comments we make can be annoying, but after a few contributions,...

@ChinYing-Li your code is not compiling 

See `WidgetZoomHandler::apply_scale_factor`

You mentioned why somewhere but I forgot where 🤦‍♂ Then my question is why ?

Go ahead @hbina :)

@hbina For any problem you encounter with compilation, you should ask for help in #compiling on our discord https://discord.gg/dNCE5J8

@AyushRaj8271 It's possible that the last PR #2869 doesn't replace all occurences. You can check in the code