Remove all occurrences of `foundation::each<>` and `foundation::const_each<>`

[dictoon]

Replace them by range-based for loops.

[oktomus]

You mentioned why somewhere but I forgot where 🤦‍♂ Then my question is why ?

[dictoon]

Since C++11 introduced range-based for loops, we no longer need our custom mechanism anymore: it doesn't bring anything over range-based for loops. The only case where a similar custom mechanism could be useful is for reverse iteration.

[hbina]

If no one is working on this I would like to take it

[oktomus]

Go ahead @hbina :)

[hbina]

@oktomus I have been trying to extract the tar file here https://github.com/appleseedhq/linux-deps/releases/download/v2.1/appleseed-deps-shared-2.1.tgz but for whatever reason I have insufficient permission. Do I really need to sudo?

Edit : I managed to extract it but I am having troubles compiling with cmake...It's a strange process to say the least.

Target architecture: x86_64
-- Using gcc 7 as the compiler
-- Found Boost: /home/hbina085/Documents/prebuilt-linux-deps/include/boost_1_61_0 (found suitable version "1.61.0", minimum required is "1.61") found components: atomic chrono date_time filesystem regex system thread wave missing components: serialization
-- Found LZ4: /home/hbina085/Documents/prebuilt-linux-deps/lib/liblz4.so
-- Found Boost: /home/hbina085/Documents/prebuilt-linux-deps/include/boost_1_61_0 (found suitable version "1.61.0", minimum required is "1.61") found components: python 
-- Configuring done
CMake Warning at src/appleseed/CMakeLists.txt:2276 (add_library):
  Cannot generate a safe runtime search path for target appleseed because
  files in some directories may conflict with libraries in implicit
  directories:

    runtime library [libz.so] in /usr/lib/x86_64-linux-gnu may be hidden by files in:
      /home/hbina085/Documents/prebuilt-linux-deps/lib

  Some of these libraries may not be found correctly.


CMake Warning at src/appleseed.shared/CMakeLists.txt:67 (add_library):
  Cannot generate a safe runtime search path for target appleseed.shared
  because files in some directories may conflict with libraries in implicit
  directories:

    runtime library [libz.so] in /usr/lib/x86_64-linux-gnu may be hidden by files in:
      /home/hbina085/Documents/prebuilt-linux-deps/lib

  Some of these libraries may not be found correctly.


CMake Warning at src/appleseed.cli/CMakeLists.txt:54 (add_executable):
  Cannot generate a safe runtime search path for target appleseed.cli because
  files in some directories may conflict with libraries in implicit
  directories:

    runtime library [libz.so] in /usr/lib/x86_64-linux-gnu may be hidden by files in:
      /home/hbina085/Documents/prebuilt-linux-deps/lib

  Some of these libraries may not be found correctly.


CMake Warning at src/appleseed.python/CMakeLists.txt:148 (add_library):
  Cannot generate a safe runtime search path for target appleseed.python
  because files in some directories may conflict with libraries in implicit
  directories:

    runtime library [libz.so] in /usr/lib/x86_64-linux-gnu may be hidden by files in:
      /home/hbina085/Documents/prebuilt-linux-deps/lib

  Some of these libraries may not be found correctly.


CMake Warning at src/appleseed.studio/CMakeLists.txt:476 (add_executable):
  Cannot generate a safe runtime search path for target appleseed.studio
  because files in some directories may conflict with libraries in implicit
  directories:

    runtime library [libz.so] in /usr/lib/x86_64-linux-gnu may be hidden by files in:
      /home/hbina085/Documents/prebuilt-linux-deps/lib

  Some of these libraries may not be found correctly.


CMake Warning at src/tools/animatecamera/CMakeLists.txt:54 (add_executable):
  Cannot generate a safe runtime search path for target animatecamera because
  files in some directories may conflict with libraries in implicit
  directories:

    runtime library [libz.so] in /usr/lib/x86_64-linux-gnu may be hidden by files in:
      /home/hbina085/Documents/prebuilt-linux-deps/lib

  Some of these libraries may not be found correctly.


CMake Warning at src/tools/convertmeshfile/CMakeLists.txt:52 (add_executable):
  Cannot generate a safe runtime search path for target convertmeshfile
  because files in some directories may conflict with libraries in implicit
  directories:

    runtime library [libz.so] in /usr/lib/x86_64-linux-gnu may be hidden by files in:
      /home/hbina085/Documents/prebuilt-linux-deps/lib

  Some of these libraries may not be found correctly.


CMake Warning at src/tools/denoiser/CMakeLists.txt:49 (add_executable):
  Cannot generate a safe runtime search path for target denoiser because
  files in some directories may conflict with libraries in implicit
  directories:

    runtime library [libz.so] in /usr/lib/x86_64-linux-gnu may be hidden by files in:
      /home/hbina085/Documents/prebuilt-linux-deps/lib

  Some of these libraries may not be found correctly.


CMake Warning at src/tools/dumpmetadata/CMakeLists.txt:51 (add_executable):
  Cannot generate a safe runtime search path for target dumpmetadata because
  files in some directories may conflict with libraries in implicit
  directories:

    runtime library [libz.so] in /usr/lib/x86_64-linux-gnu may be hidden by files in:
      /home/hbina085/Documents/prebuilt-linux-deps/lib

  Some of these libraries may not be found correctly.


CMake Warning at src/tools/makefluffy/CMakeLists.txt:51 (add_executable):
  Cannot generate a safe runtime search path for target makefluffy because
  files in some directories may conflict with libraries in implicit
  directories:

    runtime library [libz.so] in /usr/lib/x86_64-linux-gnu may be hidden by files in:
      /home/hbina085/Documents/prebuilt-linux-deps/lib

  Some of these libraries may not be found correctly.


CMake Warning at src/tools/projecttool/CMakeLists.txt:52 (add_executable):
  Cannot generate a safe runtime search path for target projecttool because
  files in some directories may conflict with libraries in implicit
  directories:

    runtime library [libz.so] in /usr/lib/x86_64-linux-gnu may be hidden by files in:
      /home/hbina085/Documents/prebuilt-linux-deps/lib

  Some of these libraries may not be found correctly.


-- Generating done
-- Build files have been written to: /home/hbina085/git/appleseed/build

Edit : Fixed that...now I have a different problem xd

I don't understand the part about setting up the local Python environment at all...

Edit: Its segfaulting...

[oktomus]

@hbina For any problem you encounter with compilation, you should ask for help in #compiling on our discord https://discord.gg/dNCE5J8

[darthgera123]

hi is this issue still open? I would like to work on it

[dictoon]

Yes it is still open.

[prat31]

I would like to work on this. Is it still open?

[dictoon]

It is.

[AyushRaj8271]

hey @dictoon! Is this issue still open?

[oktomus]

@AyushRaj8271 It's possible that the last PR #2869 doesn't replace all occurences. You can check in the code

[ganesh1828]

Hello, is this issue still open ? If yes I would like to work on it. Can you please assign me this issue.

[oktomus]

Hi @ganesh1828 ,you can work on it directly and submit a PR.

[ganesh1828]

Hi @oktomus / @dictoon I think this issue is solved in #2869 PR. You can close this issue.