Oleg Kalnichevski

Results 33 comments of Oleg Kalnichevski

@georgberky I ended up doing exactly the same, abstract test classes with nested concrete implementations, for Apache HttpClient. It gets the job done but is ugly as hell.

@arturobernalg The problem is not about executing TLS handshakes multiple times but about running multiple TLS sessions over the _same connection_ layered one over another.

> @ok2c thanks for the deep dive—if I’m reading this right, `InternalDataChannel` permanently locks in TLS on the first handshake, so you simply can’t layer a second one on the...

@arturobernalg Please rather focus on https://github.com/apache/httpcomponents-client/pull/580 instead or if you want to work on something really complex consider looking into an event-driven implementation of GZIP for the async transport

> @ok2c would you mind to validate this PR. @arturobernalg Sure. Will do.

@michael-o We cannot remove old implementation unless we are willing to go to the major release cycle and release these changes as 6.0. I suggest that the old classes are...

> I don't think that removing deprecation is problem, especially as these classes were deprecated without providing a replacement, not because they were replaced by something. @stoty Un-deprecate those classes...

@stoty @michael-o Folks, what is the reason this PR is stuck? @stoty Please rebase the latest off master to pick up Docker based compatibility tests. Feel free to disable `japicmp`...

@stoty If you want to expedite the review process we could do the following. Once you are more or less happy with the state of things, submit changes to `HttpAutheticator`...

> I have also added and @internal annotation to HttpAuthenticator, I cannot imagine realistic user code calling that directly. (though it does not seem to apply retroactively) @stoty There is...