ojab comments

Results 67 comments of


                                            ojab

Start connection in `Net::HTTP` adapter for mocked requests

Ready to review because CI waits for approval, `rspec spec/acceptance/net_http/` is green locally.

Start connection in `Net::HTTP` adapter for mocked requests

Sentry prompted me to look into that and I didn't saw any issues about it in other places, but overall it should make mocking more correct and shouldn't bring much...

SDK Fingerprinting examples missing for Ruby SDK

I guess this one is fixed by https://github.com/getsentry/sentry-docs/pull/3578

Use thread local variables instead of class variables

Actually there is a use case for thread local variables: [Celluloid](https://github.com/celluloid/celluloid) runs actors in separate threads, but different calls to actors are run in different Fibers. [Testcase](https://gist.github.com/ojab/5360212db425448cf66f) shows that fibers...

Add authentication support to Net::HTTP.SOCKSProxy

ping @musybite

Add authentication support to Net::HTTP.SOCKSProxy

Thanks!

Add authentication support to Net::HTTP.SOCKSProxy

I've rebased PR #22 on current master (1.7.0) and put patch for this PR on top, please let me know if something should be changed.

Add authentication support to Net::HTTP.SOCKSProxy

I don't use socksify any more, so unfortunately I can't test this change.

don't treat skipped jobs as cancelled

What happens when some of the jobs are failed and dependent job is canceled?

Mark skip actions as not cancelled

What happens when some of the jobs are failed and dependent job is canceled?