socksify-ruby icon indicating copy to clipboard operation
socksify-ruby copied to clipboard

Published 20 hours ago • verified publisher icon astro

Add authentication support to Net::HTTP.SOCKSProxy

Open ojab opened this issue 9 years ago • 9 comments

ojab avatar Sep 03 '15 10:09 ojab

Cool, thank you. Please ping the new maintainer @musybite if nothing happens for a few days.

astro avatar Sep 04 '15 18:09 astro

ping @musybite

ojab avatar Nov 30 '15 10:11 ojab

Thank you for pull request @ojab and sorry for long silence. Everything looks good to me. I'll make release this weekend.

musybite avatar Dec 07 '15 21:12 musybite

Thanks!

ojab avatar Dec 07 '15 21:12 ojab

I've rebased PR #22 on current master (1.7.0) and put patch for this PR on top, please let me know if something should be changed.

ojab avatar Dec 08 '15 11:12 ojab

@musybite I wonder if this will be merged & released?

mikecmpbll avatar Sep 08 '16 11:09 mikecmpbll

@musybite @astro any way that this can be merged? thanks!

ajimix avatar Jul 12 '17 17:07 ajimix

@ojab @ajimix @mikecmpbll i'd proposed another implementation in MR #33. API is fully the same. Could you check whether it works for you?

I have certain doubts about switching from class @@-variables to thread-local variables: for example, it will definitely break socksify_ruby script for multi-threaded apps, and could lead to other unintended consequences. From the very beginning, socksify implied "global socksification" of whole application with all its threads, and thread-safe (albeit somewhat ugly) APIs were added only recently. For such old and stable project as socksify, it is important not to break compatibility.

musybite avatar Mar 13 '18 20:03 musybite

I don't use socksify any more, so unfortunately I can't test this change.

ojab avatar Mar 14 '18 04:03 ojab