ohmayr
ohmayr
The current setup for `showcase` tests covers `gRPC` and `gRPC+REST` but does not include a `REST` only transport. This is a gap in our tests that we need to fill...
The following note for rest transport in the client parameters for sync client and async client needs to be removed: ```python3 NOTE: "rest" transport functionality is currently in a beta...
Currently, the [GRPC transport](https://github.com/googleapis/gapic-generator-python/blob/29af25de98ebf590214abfd6c4b40c7502bd2d11/gapic/templates/%25namespace/%25name_%25version/%25sub/services/%25service/transports/grpc.py.j2#L136) ignores any credentials passed in, if a channel is configured explicitly. For easier debugging, add a warning to notify a GAPIC developer that the channel and...
`DEFAULT_ENDPOINT` will be deprecated once `DEFAULT_ENDPOINT_TEMPLATE` is introduced as part of the changes to support the universe domain. Once those changes are completed, we should remove `DEFAULT_ENDPOINT` from the jinja...
An autogenerated snippet for google-cloud-access-approval needs to await the request call for the sample code to work as expected. Current behaviour: ```python3 # Make the request page_result = client.list_approval_requests(request=request) ```...
The following change: ```python3 self._api_endpoint = self._client._api_endpoint ``` in [asyncClient](https://github.com/googleapis/gapic-generator-python/blob/478066385450ee01df3ef9fadd68a14f5cc085ef/gapic/templates/%25namespace/%25name_%25version/%25sub/services/%25service/async_client.py.j2#L194) by this [PR](https://github.com/googleapis/gapic-generator-python/pull/1873) is added to not break the unit tests. This can be removed once `api endpoint` is added...
The method [`get_mtls_endpoint_and_cert_source`](https://github.com/googleapis/gapic-generator-python/blob/29af25de98ebf590214abfd6c4b40c7502bd2d11/gapic/templates/%25namespace/%25name_%25version/%25sub/services/%25service/client.py.j2#L220) is no longer used in the client i.e. see the following: https://github.com/googleapis/gapic-generator-python/pull/1873 This method can be deprecated after the PR https://github.com/googleapis/gapic-generator-python/pull/1868 is merged i.e. users can alternatively...
The test `//google/cloud/policytroubleshooter/iam/v3:iam_py_gapic_test` is failing once I add `google.iam.v2` as a proto-plus dependency. Steps to reproduce the issue: - Update the `google/cloud/policytroubleshooter/iam/v3/BUILD.bazel` file with the following code: ```Bazel load( "@com_google_googleapis_imports//:imports.bzl",...
An autogenerated snippet for `google-cloud-access-approval` has a missing field `parent` which results in the sample code to not work as expected. The following manual change seems to fix the issue:...