Oliver Heger

Results 29 comments of Oliver Heger

Changes look good to me, but one of the PNPM tests is failing.

To better track the progress, I propose to use this as an umbrella ticket and create separate tickets for specific package managers.

The rework of the Maven package manager (#3895) is now done (see #3894). Unfortunately, the results from first tests are rather disappointing wrt reduction of file sizes. I don't have...

Yes, within a single project, this reuse is possible, and dependencies are shared. What I meant was that there are obviously not so many duplicated elements in the dependency trees...

I can do some experiments in this direction. Seems to be an interesting problem.

There are two (trivial) issues in the static code analysis: Multiple blank lines at lines 64 and 197.

The changes look good to me, however, the commits probably need to be reworked. As stated in the [contributor guide](https://github.com/oss-review-toolkit/.github/blob/main/CONTRIBUTING.md), requested changes should not be added in new commits, but...

There are now new (unrelated) test failures, but the newly added test is successful.

@sschuberth, the test is now successful, but according to the logs, the execution of all analyzer fun tests now took 70 m. How do we proceed?

> As mentioned [above](https://github.com/oss-review-toolkit/ort/pull/5857#discussion_r978591990), I'd exclude `ExpensiveTag` tests from running as part of Batect's `funTestAnalyzer` task via `-Dkotest.tags=!ExpensiveTag`, similar to like we did in the old Azure pipelines before [4ff6895](https://github.com/oss-review-toolkit/ort/commit/4ff68955437d95400ca7f7835c6e4708bdf6694b)....