Olivier Giniaux

Results 70 comments of Olivier Giniaux

Wow nice! Performance is indeed much worse, but I was expecting even worse results tbh (like at least 2 orders of magnitude slower). That said, it is still much slower...

I think it is acceptable to split the work into two parts (software fallback first, then alternative hash fallback as an optional feature). Both imply a substantial amount of work....

Hi @virtualritz, on my end I'll try in my projects replacing occurrences of `HashMap`s with it as well :)

I checked in a few projects and I came up to the same conclusion (missing `new` and `with_capacity` because those are actually defined only for the `HashMap` with `RandomState`). What...

Thanks a lot for this analysis @orlp! Let's see if we can improve DoS resistance without compromising performance. I don't know if it can be made 100% proof but I'm...

Let's see first if we can address this 😄 Feel free to submit a PR if you want. After that, depending on the results, we can reword the DoS resistance...

Did not has much time to work on this, so in the meantime I've clarified the DOS resistance part in the readme https://github.com/ogxd/gxhash?tab=readme-ov-file#security

Mixing the seed at the start instead of the end should significantly improve DoS resistance. I'm currently (slowly) exploring this path.

Here are the results with: ```csharp [MemoryDiagnoser(false)] [ExceptionDiagnoser] [SimpleJob(RunStrategy.Monitoring, launchCount: 10, warmupCount: 10, invocationCount: 10000)] [MinColumn, Q1Column, Q3Column, MaxColumn] ``` ``` | Method | Mean | Error | StdDev |...

Started a branch: https://github.com/App-vNext/Polly/pull/2132 I added a benchmark to compare the method asking for explicit `T` to `Outcome` conversion against this implicit version using the custom awaiter: ``` | Method...