rust-term-grid

rust-term-grid copied to clipboard

Performance issue with the redundancy operations

1

https://github.com/ogham/rust-term-grid/blob/1cbc10f4fd641e49c20e72afbad3f850af51ab61/src/lib.rs#L319 For this line of code, it will always update the value of widths[index], even if the value of it does not change. This introduces some redundant operations. If we...

yyzdtccjdtc

Hi! I'm reviewing this crate for inclusion in Fuchsia, and our dependency tooling works best when there's a LICENSE file in the root of the crate upload, see [regex](https://docs.rs/crate/regex/latest/source/LICENSE-MIT) for...

anp

Fixed the bugs in displaying the grid with `fit_into_width`

4

These changes were initiated to fix the behavior of term-grid in [uutils](https://github.com/uutils/coreutils)'s `ls`, which uses term-grid 0.1.7 but can't upgrade to 0.2.0 due to the existence of these bugs. Ideally,...

mtsoltan

Fix fit to grid failing in a common case

2

An off-by-one error. Fixing it broke some other tests, so I made a few other changes. Fix #11 See: ogham/exa#990

ariasuni

[uutils](https://github.com/uutils/coreutils)'s `ls --color` re-calculates widths, passing them explicitly to cells, because terminal colors ruin the width calculation of term-grid. Ideally, term-grid should recognize color escape sequences and treat them as...

mtsoltan

Bug in smallest_diminesions_yet calculation?

1

I believe this for loop code https://github.com/ogham/rust-term-grid/blob/99396dd62e2a683ce4ddb1f6ce46612c4eabc3d7/src/lib.rs#L383 should be inclusive ```rust for num_lines in (1..=theoretical_max_num_lines).rev() { ``` I ran into this problem where the output should've been 2 rows but...

fdncred

Plans to support graphs and borders?

1

Are there any plans to support graphs (like tress) and borders?

behnam