rust-term-grid icon indicating copy to clipboard operation
rust-term-grid copied to clipboard
verified publisher icon ogham

Fix fit to grid failing in a common case

Open ariasuni opened this issue 4 years ago • 2 comments

An off-by-one error. Fixing it broke some other tests, so I made a few other changes.

Fix #11

See: ogham/exa#990

ariasuni avatar Dec 26 '21 18:12 ariasuni

@ogham any chance this can get merged? Or is this project abandoned/unmaintained?. I tested this and it fixes https://github.com/ogham/exa/issues/990

jbrubake avatar Oct 07 '22 15:10 jbrubake

Hi @ariasuni, I work on uutils and we decided to fork this repository over the inactivity: https://github.com/uutils/uutils-term-grid. I've started with fixing https://github.com/ogham/rust-term-grid/issues/11 and have made some performance improvements. We'd love to work with you and the other exa contributors for this fork!

I've already made an issue for the test case you added in this PR, so we can discuss how to support the behaviour you describe: https://github.com/uutils/uutils-term-grid/issues/6. If you're interested, please leave your thoughts there!

Btw, I love exa. Thanks for maintaining it!

tertsdiepraam avatar Nov 20 '22 16:11 tertsdiepraam