Ofek Lev comments

Results 1177 comments of


                                            Ofek Lev

FEAT: Transition to scikit-build-core CMake-based build process

Do you mean a Hatchling build hook that invokes something as a subprocess to build the artifacts?

FEAT: Transition to scikit-build-core CMake-based build process

No the future plugin would be a build hook like this https://github.com/ofek/hatch-mypyc so Hatchling would still be the backend, nothing else would be referenced in that section. Sure if you...

FEAT: Transition to scikit-build-core CMake-based build process

I didn't know it was that far along, nice!

FEAT: Transition to scikit-build-core CMake-based build process

I am in general but not implementing the plugin directly. For that, I think one of his undergraduate researchers is assisting.

FEAT: Transition to scikit-build-core CMake-based build process

cc @henryiii

FEAT: Transition to scikit-build-core CMake-based build process

I'd recommend pushing the update so we can see the final failure message. Also if the wheel looks fine I don't quite understand what you mean about tox not working...

FEAT: Transition to scikit-build-core CMake-based build process

Ready for review?

Update Python Packaging section to use `pyproject.toml` instead of `setup.cfg`

Let me know if I can help with reviews (I maintain Hatch/Hatchling)!

Stop requiring `file` in Python packages

The new guide is here: https://pyoxidizer.readthedocs.io/en/latest/oxidized_importer_resource_files.html#porting-code-to-modern-resources-apis

Change array indent from 4 to 2 spaces

`.ini` yes for sure but `.toml` I've mostly seen 2. The official examples https://toml.io/en/v1.0.0#array and https://www.python.org/dev/peps/pep-0621/#example `tomlkit` does 2 (which is how I noticed), `toml` uses 2 in examples https://github.com/uiri/toml#quick-tutorial...