Oleh Fedorenko

Results 74 comments of Oleh Fedorenko

Thanks, @adamruzicka, rebased / squashed. Although I'd like to see green tests just in case, but I don't think there will be related failures anyway :shrug:

> Should we make `ID` an acronym to avoid renaming? We could, but it will imply that we would need to either make custom inflector for the plugin, which won't...

Ready to merge after https://github.com/theforeman/foreman/pull/10131 is merged, dropped the commit for testing with Foreman PR, the latest run was green: ![Screenshot_20240903_143351](https://github.com/user-attachments/assets/b1da9f10-313b-4833-a6c2-5d3460a33414)

Hmm, not sure why the tests from core are failing here... I had the same errors for plain Foreman, but they got fixed.

@ekohl thanks, it was indeed. Moreover, thanks to that fail we prevented a hidden issue in REX caused by the same issue. I'm afraid there might be still places we...

Ready to merge after https://github.com/theforeman/foreman/pull/10131 is merged, dropped the commit for testing with Foreman PR, the latest run was green: ![Screenshot_20240903_143351](https://github.com/user-attachments/assets/ad980b9f-d1d0-4e5d-87fc-3bcb30c025af)

tasks and REX are done, ansible is pending

Well, theforeman-rubocop caused few issues for me: 1. It through dependencies requires latest concurrent-ruby, which causes problems with dynflow, which requires a specific version, thus making bundle install to fail...