Oleh Fedorenko
Oleh Fedorenko
Well, LGTM, but it appears that we have the same as part of https://github.com/theforeman/foreman/pull/9906. Should we maybe merge that instead? (sorry @stejskalleos, should've found it earlier than make you make...
I've noticed that it works on Ruby 3.0 though... So as a different solution we could bump here safemode to `< 1.4.0` until we drop Ruby 2.7 support, in that...
> I din't think we can both support Ruby 3 and safemode < 1.4. You will also need to revert the changes to use the safe operator, but I expect...
> So could this be something that safemode does? Yes. In safemode every method is removed and every call must go through `method_missing` to ensure it's "safe to call". We...
> But we can write a test that renders the report using safemode, right? It would be more of an integration test, but I always find those to be useful...
> @ekohl @ofedoren Once you two agree on a path forward here, I will make the changes and update. AFAIU, we agreed that this PR needs an integration like test,...
@archanaserver, there are still two issues related to minitest: https://github.com/theforeman/foreman/actions/runs/8004471095/job/21861933764?pr=9977
> For plugin usage, see https://github.com/theforeman/foreman/pull/10038/files Wrong link? :)
Also, after thinking why we didn't have this earlier, we did, but just in a different way: https://github.com/theforeman/foreman_openscap/blob/master/db/seeds.d/75-job_templates.rb. Does it mean this PR should unify the way the templates are...
> We can introduce `app/templates/$type`. I'd give my vote for that. Even though I'm quite used to look for the templates in `app/views`, it still pokes me in the eye...