Heather Anderson

In case you haven't heard from other places by now, it looks like Google has been heavily restricting use of OAuth to apps they have explicitly reviewed and approved. In...

Currently there are three interfaces being introduced here: * __ScriptEngine__, to abstract access to QScriptEngine. It will only be creatable from a factory function. * __ScriptValue__, to abstract access to...

I'm unsure what to do to make sure "tests" and "tests-manual" work, offhand they don't appear to be part of the project that gets compiled.

If it helps, here are one-line descriptions for at least the classes in script-engine: http://protocol.odys.se/script-engine/annotated.html [ScriptInterface] are new abstract classes to create engine-independent interfaces [QtScript] are classes deemed qtscript-specific and...

I haven't done any testing of this outside of windows interface, however there's enough green lights showing up with this that I think it's ready to get poked at by...

This latest commit has increased my concern about ScriptContext being primarily a shared_ptr. It *can* make sense in some circumstances but definitely not as a general fact. Need to review...

Reviewed the code again and ScriptContext is a C++ wrapper around a script engine object that is always a shared_ptr, even if the engine object isn't.

I've just created a rough diff of ScriptEngine and ScriptManager at https://github.com/odysseus654/vircadia/commit/4f631e5d9dd551962059ed55f827c7f29abea399, hoping this helps code review

I'm okay with merging master into this PR to clear up the conflicts if/when it wouldn't make any code reviews more difficult than they already are.

The crash dump is unreadable, can you please register the symbols with Sentry and try again?