Chengxu Bian
Chengxu Bian
Looks like a linking error happened on Ubuntu 22.04. 👀 https://github.com/odysa/llama-rs/actions/runs/4449174539
As a user of aiokafka, I like typing hints. I want to contribute to the typing feature. Where should I start from?
Is `dotenv` required in poetry dependency? 👀
Hi, is this what you refer to? Can you plz explain more about "careful to runtime agnostic"? Is there anything we need to be careful when implementing concurrent scanning? https://github.com/apache/iceberg-rust/blob/9768b0ef1c7ab3631f69ee52d18ea928e4a4250f/crates/iceberg/src/scan.rs#L140-L145
> I mean we may need an extra layer for task scheduling, so that we can be adopted to any async runtime such as tokio, async-std. Do you want users...
> Do you want users to choose their own runtime like [sqlx](https://github.com/launchbadge/sqlx/tree/main?rgh-link-date=2024-02-02T17%3A02%3A32Z#install)? They are building an abstraction layer([Runtime](https://github.com/launchbadge/sqlx/tree/next/sqlx-core/src/runtime?rgh-link-date=2024-02-02T17%3A02%3A32Z)) so `sqlx` can run on many blocking/non-blocking runtime. Follow up on this....
Sorry, my bad. I thought I marked this PR ready for review, but I didn't remove the [WIP]. There are some code changes needed to resolve conflicts. Let me know...
> cc @odysa Are you still interested in working on this? I just got back from vacation today. Let me start working on it.
Made code change. Now tokio is always a dependency since traits like `AsyncWrite` are used. Do you have any plan for them? I made `tokio` a default feature to avoid...
Now we run tests by `--all-features` https://github.com/apache/iceberg-rust/blob/854171d42199f756d2ad1a81a742ce61d9299f05/.github/workflows/ci.yml#L73 Maybe we can have specific tests for tokio and async-std?