Denis Otkidach

Hi @tartieret, Could you please provide tests for it?

> I'll work on the requested tests. Are tests all that is preventing this from getting merged? Yes, tests for it is the most important part. There is also some...

Replaced with https://github.com/aio-libs/aiokafka/pull/941

Outdated

> Could we get a release with the admin client? What version do you use and what problem do you have? aiokafka 0.8.1 does include admin client, i.e. `from aiokafka.admin...

> But then after looking into it and **understanding the problem and more importantly, the rationalle for the solution, it makes perfect sense for doc strings / block quotes to...

Hi @apmorton, Thank you for reproducing the problem. Right, in Python from 3.8.6 there was [a bug](https://bugs.python.org/issue43389) in `asyncio.wait_for()` which was [fixed](https://github.com/python/cpython/issues/96764) in 3.12 by using the same approach, as...

Other similar places we also can have problems with: - https://github.com/aio-libs/aiokafka/blob/master/aiokafka/consumer/fetcher.py#L456-L457 - https://github.com/aio-libs/aiokafka/blob/master/aiokafka/consumer/group_coordinator.py#L761-L762 - https://github.com/aio-libs/aiokafka/blob/master/aiokafka/consumer/group_coordinator.py#L889-L890 - https://github.com/aio-libs/aiokafka/blob/master/aiokafka/producer/sender.py#L98-L99

Here is a snippet to demonstrate the problem with just suppressing `CancelledError`: ```python import asyncio from time import time async def task_with_cleanup(): try: await asyncio.sleep(1000) finally: print("Cleanup", time() - started)...

@webknjaz, are you at EuroPython now? Let's meet in person