Denis Otkidach

Results 101 comments of Denis Otkidach

Yes, we're interested in adding type hints. I'd like to highlight some issues here. - Incorrect types are often worse that missing types - Gradual approach doesn't work good here:...

> https://github.com/aio-libs/aiokafka/pull/981 should I close this PR? I hope to find time on weekend to look through it.

@antonagestam, thanks for the suggestion! It looks interesting, definitely worth to try. Do you use it via [pytest-beartype](https://github.com/beartype/pytest-beartype) or in some other way?

Hi @odysa, thank you for your willingness to contribute! Probably we need more communication with interested people to discuss problems. Let me highlight some difficult places: - It would be...

Sounds reasonable. But I have no rights to manage aiokafka at PyPI, only to publish via CI.

Why do you suspect `crc32c.c`/`crc32s.h`? They don't include `Python.h` and don't deal with Python objects conversion. Do you install binary package or compile it from source? If later, what Cython...

> getting below error when trying to consume from a ZSTD compressed record from kafka. > > raise UnsupportedCodecError( kafka.errors.UnsupportedCodecError: UnsupportedCodecError: Libraries for zstd compression codec not found Did you...

What version of kafka did you get this error? It should be [fixed in 2.5.0](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=89068820).

We may consider removing kafka-python from dependencies, as even issues with PRs are not merged into master.

Hello @rujutashinde, thank you for reminding. Unfortunately I don't have enough expertise to make this PR production ready. Would you like to participate?