Odin Ugedal

Thanks for the comments @christarazi! Fixed most stuff now, but will take another look when i get to work on Monday morning. Also write a proper commit msg as well!

I've also updated my benchmark code btw., and made a proper README highlighting how the various things improve the perf; https://github.com/odinuge/cilium-fqdn-regex-benchmarking/blob/master/README.md

Thanks for all the reviews! Some updates; - Updated a lot of the godocs as suggested by @aanm and @christarazi - Fixed the `UpdateAllowedFromSelectorRegexes` func - Added support for `nil`...

Chatted with @christarazi offline about this. Due to complexity getting this backported, we decided to go for ~https://github.com/cilium/cilium/compare/master...odinuge:ou-testing-only-regex for now, and do this approach after we have gotten that initial...

> This is fine. Maybe for a more user-focused release-note it would say something like "improve memory usage for encoding endpoint objects into JSON". Ack. Thanks! Updated the PR message...

Oooh, yee, you are right @aanm, thanks! It looks legit as well. Will fix!

Thanks all! Sorry for missing that obvious test.. Made the test compare with the compacted json, and it passes locally when running `(cd pkg/policy; go test -check.v -check.vv)`.

Its not clear to me that the test failures are due to this change.. Can we rerun them to check @joestringer? Thanks

Hmm, I see. Thanks! The errors seems similar to these; https://github.com/cilium/cilium/issues/16122 With erros like these; ``` /home/jenkins/workspace/Cilium-PR-K8s-1.23-kernel-4.19/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:527 Failed to reach 192.168.56.12:80 from testclient-27jkk Expected command: kubectl exec -n 202208042322k8sdatapathconfighostfirewallwithnativeroutinganden testclient-27jkk...

Been digging a bit today as well, but can't really see how this change can cause those tbh. Under the hood `json.MarshalIndent` will call `json.Marshal`, then add some spaces and...