Emmanuel T Odeke issues

Results 183 issues of


                                            Emmanuel T Odeke

package name discrepancies in suffixes: /core for stats vs /nodejs for tracing

Thank you for the work on the Node.js implementation! I just noticed a weird discrepancy in the NPM package names. For tracing, we need: ```javascript var tracing = require('@opencensus/nodejs'); ```...

question

GA-Effort

example: HTTP circuit breaker doesn't consider HTTP status codes which are more indicative of retryable errors

The circuit breaker pattern as per the linked docs is to allow retrying of operations that are less likely to fail. With the current code in example/ if I encounter...

pkg/utils: GetBBProject should hoist out the static string built regex as a global and invoke panics not os.Exit(1)

From Orijtech Cyber's audits of earlybird, we noticed that this code could be hoisted out and made a global given that the regular expression is constructed from a constant/static string...

good first issue

fix code and performance audit findings

Hello American Express, from [Orijtech Cyber](https://cyber.orijtech.com/) we performed an audit of your software earlybird security secrets scanner and a great contribution to improving supply chain security generally, thank you! Please...

help wanted

nit: x/auction/keeper: Keeper.EndBlocker could succinctly use !sdk.Dec.IsPositive and not having to compare against a zero magnitude sdk.Dec

Noticed here that we've got this comparison https://github.com/PeggyJV/sommelier/blob/3157d97e1576da7e31adbf5a792aeac6a23a1894/x/auction/keeper/abci.go#L39 but really that can be succinctly and cheaply be turned into !.IsPositive()

x/axelarcork/keeper, x/cork/keeper: HandleRemoveManagedCellarsProposal should bail out immediately found=true to avoid needless/wasted iterations

## Summary of Bug The loops here https://github.com/PeggyJV/sommelier/blob/3157d97e1576da7e31adbf5a792aeac6a23a1894/x/cork/keeper/proposal_handler.go#L62-L70 and https://github.com/PeggyJV/sommelier/blob/3157d97e1576da7e31adbf5a792aeac6a23a1894/x/axelarcork/keeper/proposal_handler.go#L41-L47 iterate looking for a specific target but once it has found it just keeps iterating and comparing over all all...

all: can avoid the use of bytes.Buffer and .Next simply by reslicing, since bytes.NewBuffer has an allocation and CPU time cost

## Summary of Bug Noticed throughout the repository that there is this pattern https://github.com/PeggyJV/sommelier/blob/3157d97e1576da7e31adbf5a792aeac6a23a1894/x/cork/keeper/keeper.go#L103-L108 ## Suggestion Simply use byte slicing which can be made so much clearer and removes unnecessary...

x/cellarfees/keeper: remove unnecessary iterations predicated on an AND condition that could be checked immediately that an auction interval occured

## Summary of Bug If we look at this code https://github.com/PeggyJV/sommelier/blob/3157d97e1576da7e31adbf5a792aeac6a23a1894/x/cellarfees/keeper/abci.go#L19-L28 we see that in the condition to reset the counters, modulus MUST BE == 0! This means that if...

x/auction/keeper: IterateAuctions and other helpers should be returning pointers to unmarshalled objects to avoid awkward APIs that consume pointers yet receive values

Please update the iterator consumer to take auction pointers and not values because the consumers of the APIs end up needing pointers and that all becomes awkward ![image](https://github.com/PeggyJV/sommelier/assets/4898263/ac36f0f4-0614-4811-b017-1924ee2860a0)

app: (*SommelierApp).prepForZeroHeightGenesis should instead use a defer iter.Close() to ensure that the store gets closed on any panic

## Summary of Bug Given the usage of panics down below ![image](https://github.com/PeggyJV/sommelier/assets/4898263/a8b6ab2a-d063-4f58-8602-78358fea6085) in this code section https://github.com/PeggyJV/sommelier/blob/3157d97e1576da7e31adbf5a792aeac6a23a1894/app/export.go#L155-L174, despite having an iter.Close() down at Line 174, it is important to use...