Emmanuel T Odeke

UnmarshalBinary and UnmarshalJSON should not panic on nil deference

1

The above codec methods should return an error like the stdlib does instead of panicking. I agree this is too distracting for us not to gracefully fail. https://play.golang.org/p/ltv0I7O_YjS ```go package...

DecodeByteSlice is susceptible to overflow from extraneous int(count) casts and can crash make([]byte, n) with special values

4

So take a look at the code in https://github.com/tendermint/go-amino/blob/df56f863670d5654f1314b20572d58dd5bf8e548/decoder.go#L262-L281 Notice in there that we start with https://github.com/tendermint/go-amino/blob/df56f863670d5654f1314b20572d58dd5bf8e548/decoder.go#L265 We should be wary that `make` takes a max of maxInt, and passing...

sdk2: fix invalid and expensive byte trim code

2

I was just reviewing the code to see why our tests take 67seconds to run and noticed that throughout in the code we have patterns of code such as https://github.com/tendermint/go-wire/blob/c7801c1586f51bb28028cd420c599516d7ac9c36/reflect.go#L809-L811...

WriteJSON: handle marshaling nil as a top level value

3

Go's "encoding/json" can successfully marshal a nil value, whether it is typed or not for example https://play.golang.org/p/dZ_N86Onh8 or inlined ```go package main import ( "encoding/json" "fmt" ) func main() {...

codecs: implement custom byte types Vs only Bytes and defining global codecs

2

@jaekwon asked me to post up some comments that I made on PR https://github.com/tendermint/tmlibs/pull/102 about defining codecs instead of just defining custom byte types. **TL;DR:** instead of defining multiple codecs...

If we examine the code in here https://github.com/tendermint/tm-db/blob/b3c748f0152befceed0727d934fecb923fc0ed8e/remotedb/grpcdb/server.go#L19-L28 we notice that after we invoke net.Listen there is a listener in there that'll be bound to an address, but if any...

exporters/agent: add Python ocagent-exporter guide

1

Please take a look at https://github.com/census-instrumentation/opencensus-website/issues/559 which is now live at https://opencensus.io/exporters/supported-exporters/go/ocagent/

While working on a bug, I examined the work we did documenting the Google Cloud Bigtable client as per https://opencensus.io/integrations/google_cloud/google_cloud_bigtable/go/#end-to-end-code-sample and noticed that we are creating two (*bigtable).AdminClient-s but only...

core-concepts/exporters: missing guide for creating a customer exporter

3

So in the latest revamp we've got a section `core-concepts/exporters` https://opencensus.io/core-concepts/exporters/ which is great. However, we don't provide a section for a developer guide: * Actually explaining what exporters are...

guides/HTTP: add Java's Jetty integration guide

3

Currently on the website we've got a section for the Go net/http integration's for both client and server. Let's also document for how to use OpenCensus with the Jetty integration...