Emmanuel T Odeke

@bslatkin ping!

> pinged bez and Manuel who have been doing deep dives and auditing/speccing out the store package Hehe @tac0turtle I was reviewing it right as you were pinging me and...

@yihuang, currently as is, the benchmarks need one to keenly look and they are from single passes; the way to properly demonstrate your benchmarks is by: * Run benchmarks before...

> @odeke-em Can you enlighten me on this part of code, I actually don't understand what's the purpose here: https://github.com/cosmos/cosmos-sdk/blob/main/store/cachekv/memiterator.go#L46-L51 It checks that if the currently looked up key was...

@JulianToledano thank you for this change! Please rebase the latest code from main and update this PR.

@JeancarloBarrios on reading the code again, I think we can just simply use len(nameOfMap) instead of also maintaining a txCount as that's redundant and now unnecessary.

> > Nice work and thank you @JeancarloBarrios! LGTM from a security, performance and Go review perspective. I've added some extra comments though. One thing though is ensure we document...

> Could you touch on what this does? Do we need to add it to ci? Git hook? @tac0turtle it uses Go's new vulnerability scanner to check for packages that...

> @odeke-em Are you able to make another round of review, given https://github.com/cosmos/cosmos-sdk/pull/13696#discussion_r1032848163? Some of my review comments weren't addressed but I'd say from a performance and security perspective we...

Ack, I have added an action item to myself and should hopefully get time and work on this in the next 36 hours. Thanks for the ping @songy23!