cosmos-sdk icon indicating copy to clipboard operation
cosmos-sdk copied to clipboard

Published 20 hours ago • verified publisher icon cosmos

fix: remove rosetta from server start

Open JulianToledano opened this issue 2 years ago • 5 comments

Description

Closes: #14041

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.

I have...

  • [x] included the correct type prefix in the PR title
  • [ ] added ! to the type prefix if API or client breaking change
  • [ ] targeted the correct branch (see PR Targeting)
  • [x] provided a link to the relevant issue or specification
  • [ ] followed the guidelines for building modules
  • [ ] included the necessary unit and integration tests
  • [x] added a changelog entry to CHANGELOG.md
  • [ ] included comments for documenting Go code
  • [ ] updated the relevant documentation or specification
  • [ ] reviewed "Files changed" and left comments if necessary
  • [ ] confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • [ ] confirmed the correct type prefix in the PR title
  • [ ] confirmed ! in the type prefix if API or client breaking change
  • [ ] confirmed all author checklist items have been addressed
  • [ ] reviewed state machine logic
  • [ ] reviewed API design and naming
  • [ ] reviewed documentation is accurate
  • [ ] reviewed tests and test coverage
  • [ ] manually tested (if applicable)

JulianToledano avatar Nov 29 '22 10:11 JulianToledano

@JulianToledano thank you for this change! Please rebase the latest code from main and update this PR.

odeke-em avatar Nov 29 '22 13:11 odeke-em

TBH, I'm not sure this belongs under Bug Fix. Perhaps Improvement. We also need to mention it in breaking changes due to the config struct changing.

alexanderbez avatar Nov 29 '22 14:11 alexanderbez

TBH, I'm not sure this belongs under Bug Fix. Perhaps Improvement. We also need to mention it in breaking changes due to the config struct changing.

you mean in the api breaking section?

JulianToledano avatar Nov 29 '22 15:11 JulianToledano

@JulianToledano could you enable the maintainers to update your branch to latest?otherwise we are playing a chasing game with you updating the pr

tac0turtle avatar Nov 30 '22 10:11 tac0turtle

@JulianToledano could you enable the maintainers to update your branch to latest?otherwise we are playing a chasing game with you updating the pr

Should we add you as collaborators ? or how can we give you guys that permission ?

raynaudoe avatar Nov 30 '22 15:11 raynaudoe