Daniel Opitz

Results 52 comments of Daniel Opitz

Hi! :-) Thanks for this awesome package! I just wanted to say that I and a lot of people in the Slim-Framework community looking forward to this release, because since...

Here is my feedback. I have just tested PHP-DI version `v7.x-dev` on my dev environment and on Github Action with PHP 8.0 and PHP 8.1 in combination with Slim 4.8....

Not sure what you mean. Have you tried this package for Smarty and Slim 4? * https://github.com/mathmarques/Smarty-View

I think these methods should not be set to protected, otherwise we have to deal with unexpected breaking changes later on. A custom error handler would be a better approach...

~I think that would go beyond the scope of Slim.~ By default, Slim controllers have a strict signature: `$request, $response, array $args`. The [PHP-DI bridge](https://github.com/PHP-DI/Slim-Bridge) offers an alternative, for strictly...

That's right, obviously this feature was added in version 4.1. https://github.com/slimphp/Slim/pull/3132 I was not aware of that, and the reference is not yet included in the documentation. I guess this...

I would mention here that this specific approach (rely on an array key of the logger context) would imply some kind of indirect "contract", which I do not consider optimal....

Slim 3 is no longer fully supported. Why don't you try Slim 4 instead? Note that we also have a special Discourse [forum](https://discourse.slimframework.com/) for questions like this.

I have tried to reproduce your posted issue. Here are my test results using postman: GET /articles/123 Response: `123` GET /articles/9%65 Response: `9e` Single encoding: 9e (same) GET /articles/9%2565 Response:...

The first url-encoding happens before that actual routing. See [RouteResolver](https://github.com/slimphp/Slim/blob/4.x/Slim/Routing/RouteResolver.php#L42). This is needed for the FastRouter dispatcher and a correct behavior. So this: `/articles/9%2565` becomes this `/articles/9%65` Then, when Slim...