Florian Forster

Results 101 comments of Florian Forster

The _memory plugin_ is using `int mib[] = {CTL_VM, VM_METER};` which looks to be an obsolete or deprecated interface on OpenBSD.

> * Adding a "kernel" timestamp format SGTM. As long as it's configurable – I suspect that a sizable part of the user base would find it inconvenient. I think...

After having used the *write_log plugin* a bunch over the last few days I can confirm that it is lacking for debugging purposes. That it defaults to the graphite format...

Hey @eero-t, I prefer to let people merge themselves, to allow them to include small post-review fixes, such as typos or additional documentation. If you want me to merge this...

Thanks for the PR @tapthaker! I think reporting of the GPU temperature is a great extension of this plugin. This PR seems to remove a bunch of functionality, e.g. "fanspeed"...

Hi @cjmayo, @dago, does one of you want to port this change to a recent version of *main* so it can be merged?

This has been fixed in e085aa877717e4a1cb5b5a318daf72b3bdfde56c

Hi @toni-moreno, thank you very much for your patch! I'll leave some review comments inline … Best regards, —octo

LGTM, I think this should go in the 5.4 branch. I want to test-compile before merging though.

Hi @radford, thank you so much for picking this up even after such a long time! Could you please run `contrib/format.sh src/curl_json_test.c` to fix the formatting of the unit test?...