Florian Forster

Results 101 comments of Florian Forster

Hi @schorsch1976, I'd love to merge this. Can you apply the suggested changes?

The tests fail due to an unrelated bug in *main* that has since been fixed in #3536. Once you have fixed the code review comments, please rebase your change on...

Hi @foxx, sorry for the late reply. What are you trying to accomplish? `(pinghost_t).timer` is reset frequently and simply exposing it as-is will not be very helpful because its semantics...

Hi @l29ah, thank you very much for your patch and sorry for the late reply! Could you share a little about the motivation for this change? It seems to be...

I'd argue that there are two feature requests in this: 1. Add running statistics to the *oping* output. (*noping* already has that) 1. Provide an option to limit statistics to...

Sounds like a great feature! Could you create a PR, @cron2? That would make it easier to test and review. Personally I would find `-a` for "all" quite intuitive for...

Hi @jquinn47, thank you very much for your patch! One of our best practices with these kinds of "categorized" metrics is to ensure that each byte is only counted once....

I think we have several options: * Figure out how the metrics relate to each other and create a separate metric. If I understand the description correctly, then the difference...

Hi @jquinn47, each outlined solution would be acceptable. Personally, I'd prefer option 1, but it is only feasible if such an easy relationship as I outlined exists. Also, I'm by...

Hey @matwey! I stumbled over this, because our build for Debian unstable currently fails with the following error: ``` src/epics.c:26:10: fatal error: cadef.h: No such file or directory 26 |...