omar

Results 1337 comments of omar

Hello @thedmd, Today I was checking all the PR ahead of working on the slight-but-PR-breaking refactor discussed in #2036. Here's a few things to chew on: ---- ### (1) I...

Great to see the patch looks much easier to track now!

For own and future reference here's a minimal pastable demo: ``` static bool spanToWindow = true; static float middleWeight = 0.30f; ImGui::Checkbox("spanToWindow", &spanToWindow); ImGui::DragFloat("middleWeight", &middleWeight, 0.01f, 0.0f, 1.0f); ImGui::BeginHorizontal("example_h1", spanToWindow...

Thanks thedmd and glad the patch is looking easier to maintain. Labelling paragraphs for easier answers. > Do you have any general plan for layouts? (A) I don't have clear...

(A) > Are you consider this to be fancier demo? Yes, I was wondering where was that code? > Stack layouts were not mend for cases like "Window Options". Yes,...

Thanks for the link/code! (A) >> (Another smaller issue with their signature is that I want the widget to be able to clip render while still proceeding, so while ItemAdd...

A) I'm not sure what "generalizing cursor movement" means. I want to make it possible to push working rectangles, and the ItemAdd/ItemSize needs rework so they handle layout and output...

(1) Here's the PR rebased over `master` as of today. [stack_layout.zip](https://github.com/ocornut/imgui/files/3138698/stack_layout.zip) I agree it'd be useful to add the demo code in imgui_demo.cpp to allow quick sanity test. (2) (For...

Thanks for the update! Will look in more details later. May be wrong but I don't think you need the change in `Indent`/`Unindent` any more? (2) I thought `ClientRect` would...

(2) for the bug I mean the workrect2 has a bug compared to master, where tree indents are lost within column. Not stacklayout’s fault more a fault of workrect+columns (i...