Oscar

Results 35 comments of Oscar

...and what it does NOT too! E.g. we get many repeated issues/questions on ip/tcp/etc. stream reassembly or things that require underlying reassembly (like full HTTP requests/responses). Also I suggest establishing...

@HugooB could you attach a pcap to reproduce the issue?

I don't get this error with changes made in PR https://github.com/kbandla/dpkt/pull/588 so hopefully it fixes both issues. @HugooB are you getting this error running ja3, or some other code? If...

> @obormot you know what this is doing? Yeah `_mod_init()`s get called after all dpkt protocol modules have initialized (ie. got imported into the global namespace I guess is another...

So just to add some context, while I don't know the most kosher way of dealing with relative imports, I've tried applying the following trick to several modules: ``` if...

Yes it does report something, but this specific piece of code didn't change => there's no drop in coverage. Perhaps there's a threshold that can be adjusted, like "treat any...

The suggested patch just adds constants (I've verified that all of them are correct, https://en.wikipedia.org/wiki/List_of_DNS_record_types and some RFCs), but it doesn't incorporate support for these added record types into dns.RR.pack_rdata()...

https://github.com/serra/sphinx-with-markdown

@itaykrk I can work on an example for you. In the meantime have you checked some of the unit tests inside pcapng.py? There are a couple tests that demonstrate writing...

FYI https://github.com/kbandla/dpkt/blob/master/examples/old/dhcprequest.py