oSumAtrIX

Results 1338 comments of oSumAtrIX

Unfortunately not. Replicate the environment of the workflow and compare what is different on yours.

Please PR this at line: https://github.com/revanced/revanced-cli/blob/a4ef47a28521f101c2fa71e423a0a39a5de8e2bf/src/main/kotlin/app/revanced/utils/adb/Constants.kt#L53

> because reflection makes the youtube app significantly slower I can not reproduce this.

No need to ask anyone else, I just have to compare it on my device. I have also tried it on an old tablet where I can not reproduce it.

> How did you try it? Also maybe its not that big of an effect right now Yes & Yes.

> So the general rule of any development is to make the code run the fastest way you can possibly do No, this is the wrong approach. Readability and understandable...

> changing the integrations to not use reflection does not make the code less readable or less understandable It very much does, due to now having to resort to an...

> I don't see how that will decrease readability. As I said previously: > due to now having to resort to an abstract approach where the patch has to embed...

https://github.com/revanced/revanced-integrations/issues/96#issuecomment-1192738420: > I can not reproduce this.