oSumAtrIX

Results 1489 comments of oSumAtrIX

You can PR code according to the contribution guidelines

Antisplit is not in scope of revanced. Report the issue to them

Signature checks need to be patched otherwise the app will crash, in any case, offtopic

Issue is not version dependent. This is a/b

There is no drain, unless you can show a side by side comparison

Some changes looked fine, may be worth it to keep the PR open with those changes

The issue is stale, closing until anyone mentions it

Yes refer to the comment in one of the linked prs

Implemented caching elegantly: The code speaks semantically. We look for a method that unconditionally has the required strings/types. (it can be extended if we add more caching stuff). And afterwards...

This is particularly useful and very powerful in dynamic scenarios such as this: You can utilize the power of the cache and do additional arbitrary filtering for partial strings