Ossama Hjaji

Results 84 comments of Ossama Hjaji
trafficstars

Thanks a lot for your input @Byron, I've created two issues as a follow up #628 and #629.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@Byron 😮 ❤️ BTW, do you have an ETA for: - [ ] config 'user.name', remote information - [ ] git status/pending changes tracking issue --> https://github.com/Byron/gitoxide/issues/364

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Following your suggestion, I plugged the repo to codecov with a ci job that will generate the coverage report (with cargo tarpaulin) and upload it to codecov automatically. 👉 https://app.codecov.io/gh/o2sh/onefetch

it's very low...maybe we should wait before putting it on display 😅 [![codecov](https://codecov.io/gh/o2sh/onefetch/branch/main/graph/badge.svg?token=P3oHskWePa)](https://codecov.io/gh/o2sh/onefetch)

As for integration tests, please make sure not to rely on the [`git2`](https://crates.io/crates/git2) crate as we are trying to get rid of it in favor of [`gitoxide`](https://crates.io/crates/gitoxide) For pointers on...

I like this approach. Does this mean we'll need to have a CLI flag `--format-numbers` in order to have it be part of the Config ? 🤔

FWIW, it seems like [`num_format`](https://github.com/bcmyers/num-format) came back from the dead https://github.com/bcmyers/num-format/issues/27#issuecomment-1272626722 😅 We should probably use it to format numbers. I'm in favor of adding a CLI flag to allow...

Hi @H4ckerxx44, can you check if #892 resolves your issue? Thanks.